Skip to content

build(sqlite): Disable modernc for WASM #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Dec 8, 2023
Merged

build(sqlite): Disable modernc for WASM #3048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build(sqlite): Disable modernc for WASM
  • Loading branch information
@kyleconroy
kyleconroy committed Dec 8, 2023
commit 7e0e0a50e490dcd56af55bf71cc210ba0f40b6e8
1 change: 0 additions & 1 deletion internal/cmd/vet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"github.com/jackc/pgx/v5"
"github.com/spf13/cobra"
"google.golang.org/protobuf/encoding/protojson"
_ "modernc.org/sqlite"

"github.com/sqlc-dev/sqlc/internal/config"
"github.com/sqlc-dev/sqlc/internal/debug"
Expand Down
7 changes: 7 additions & 0 deletions internal/cmd/vet_modernc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
//go:build !wasm

package cmd

import (
_ "modernc.org/sqlite"
)
2 changes: 0 additions & 2 deletions internal/sqltest/sqlite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import (
"testing"

"github.com/sqlc-dev/sqlc/internal/sql/sqlpath"

_ "modernc.org/sqlite"
)

func SQLite(t *testing.T, migrations []string) (*sql.DB, func()) {
Expand Down
7 changes: 7 additions & 0 deletions internal/sqltest/sqlite_modernc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
//go:build !wasm

package sqltest

import (
_ "modernc.org/sqlite"
)