Skip to content

fix: Use derived ArrayDims instead of deprecated attndims #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Dec 4, 2023
Merged

fix: Use derived ArrayDims instead of deprecated attndims #3032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Use derived ArrayDims instead of deprecated attndims
  • Loading branch information
@hendrikhofstadt
hendrikhofstadt authored Dec 4, 2023
commit e3da0542fdddd908b084b1bb30c03cbe1f0791d6
5 changes: 2 additions & 3 deletions internal/engine/postgresql/analyzer/analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,7 @@ func (a *Analyzer) Analyze(ctx context.Context, n ast.Node, query string, migrat
if err != nil {
return nil, err
}
// TODO: Why are these dims different?
dt, isArray, _ := parseType(col.DataType)
dt, isArray, dims := parseType(col.DataType)
notNull := col.NotNull
name := field.Name
result.Columns = append(result.Columns, &core.Column{
Expand All @@ -263,7 +262,7 @@ func (a *Analyzer) Analyze(ctx context.Context, n ast.Node, query string, migrat
DataType: dt,
NotNull: notNull,
IsArray: isArray,
ArrayDims: int32(col.ArrayDims),
ArrayDims: int32(dims),
Table: &core.Identifier{
Schema: tbl.SchemaName,
Name: tbl.TableName,
Expand Down