Skip to content

feat(debug): Add databases=managed debug option #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 3 commits into from
Oct 23, 2023
Merged

feat(debug): Add databases=managed debug option #2898

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
472c9b3
feat(debug): Add databases=managed debug option
kyleconroy Oct 20, 2023
5e9be80
Update vet.go
kyleconroy Oct 21, 2023
e6e1107
Update analyze.go
kyleconroy Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update vet.go 
Co-authored-by: Andrew Benton <[email protected]>
  • Loading branch information
@kyleconroy @andrewmbenton
kyleconroy and andrewmbenton authored Oct 21, 2023
commit 5e9be803c8562cb99cdd5837ec970d5cc4c3d9ac
2 changes: 1 addition & 1 deletion internal/cmd/vet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ func (c *checker) checkSQL(ctx context.Context, s config.SQL) error {
var expl explainer
if s.Database != nil { // TODO only set up a database connection if a rule evaluation requires it
if s.Database.URI != "" && c.OnlyManagedDB {
return fmt.Errorf("database: connections disabled via command line flag")
return fmt.Errorf("database: connections disabled via SQLCDEBUG=databases=managed")
}
dburl, cleanup, err := c.fetchDatabaseUri(ctx, s)
if err != nil {
Expand Down