Skip to content

feat(analyzer): Cache query analysis #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 4 commits into from
Oct 20, 2023
Merged

feat(analyzer): Cache query analysis #2889

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32996a2
feat(analyzer): Cache query analysis
kyleconroy Oct 19, 2023
9e8e89f
Fix buf lint
kyleconroy Oct 19, 2023
ea2001b
Address comments
kyleconroy Oct 20, 2023
16670c9
Fix additional comments
kyleconroy Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix additional comments
  • Loading branch information
@kyleconroy
kyleconroy committed Oct 20, 2023
commit 16670c9183e348ee148703c9c3c32f4b85692ba2
2 changes: 1 addition & 1 deletion internal/analyzer/analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import (
"encoding/json"
"fmt"
"hash/fnv"
"log/slog"
"os"
"path/filepath"

"golang.org/x/exp/slog"
"google.golang.org/protobuf/proto"

"github.com/sqlc-dev/sqlc/internal/analysis"
Expand Down
2 changes: 0 additions & 2 deletions internal/cmd/vet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ func Vet(ctx context.Context, dir, filename string, opts *Options) error {
}

c := checker{
ConfigPath: configPath,
Rules: rules,
Conf: conf,
Dir: dir,
Expand Down Expand Up @@ -379,7 +378,6 @@ type rule struct {
}

type checker struct {
ConfigPath string
Rules map[string]rule
Conf *config.Config
Dir string
Expand Down