Skip to content

fix(codegen/go): Prevent filtering of embedded struct fields #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewmbenton merged 1 commit into from
Oct 17, 2023
Merged

fix(codegen/go): Prevent filtering of embedded struct fields #2868

andrewmbenton merged 1 commit into from
Oct 17, 2023

Conversation

@andrewmbenton
Copy link
Collaborator

@andrewmbenton andrewmbenton commented Oct 17, 2023

Resolves #2860

@andrewmbenton andrewmbenton merged commit bd46afa into main Oct 17, 2023
@andrewmbenton andrewmbenton deleted the andrew/fix-omit-unused-structs-with-embed branch October 17, 2023 17:01
@p-linnane p-linnane mentioned this pull request Oct 24, 2023
Merged
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@andrewmbenton
fix(codegen/go): Prevent filtering of embedded struct fields (sqlc-de…
adf50e7 
…v#2868)

Resolves sqlc-dev#2860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

omit_unused_structs ignores enum when used with sqlc.embed

3 participants

@andrewmbenton @kyleconroy