Skip to content

fix(compiler): Support functions with OUT params #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 3 commits into from
Oct 17, 2023
Merged

fix(compiler): Support functions with OUT params #2865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4eb8296
test: add a test case for https://github.com/sqlc-dev/sqlc/issues/1654
andrewmbenton Oct 16, 2023
49eb099
fix(compiler): Support functions with OUT params
kyleconroy Oct 16, 2023
f3231cc
Add generated code
kyleconroy Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add a test case for #1654
  • Loading branch information
@andrewmbenton
andrewmbenton committed Oct 16, 2023
commit 4eb82969aa77afbc726262e20b69aa336278d442
1 change: 1 addition & 0 deletions internal/endtoend/testdata/func_out_param/issue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://github.com/sqlc-dev/sqlc/issues/1654
4 changes: 4 additions & 0 deletions internal/endtoend/testdata/func_out_param/pgx/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
-- name: CreateAuthor :one
SELECT * FROM add_author (
sqlc.arg(name), sqlc.arg(bio)
);
14 changes: 14 additions & 0 deletions internal/endtoend/testdata/func_out_param/pgx/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
-- Example queries for sqlc
CREATE TABLE authors (
id BIGSERIAL PRIMARY KEY,
name text NOT NULL,
bio text
);

CREATE OR REPLACE FUNCTION add_author (name text, bio text, out id int)
AS $$
DECLARE
BEGIN
id = 123;
END;
$$ LANGUAGE plpgsql;
14 changes: 14 additions & 0 deletions internal/endtoend/testdata/func_out_param/pgx/sqlc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
version: "2"
cloud:
project: "01HAQMMECEYQYKFJN8MP16QC41"
sql:
- engine: "postgresql"
schema: "schema.sql"
queries: "query.sql"
gen:
go:
package: "querytest"
out: "go"
sql_package: "pgx/v5"
database:
managed: true