fix(compiler): Pull in array information from analyzer

Fixes #1532
sqlc-dev · kyleconroy · Oct 18, 2023 · Oct 16, 2023 · Oct 16, 2023 · Oct 16, 2023
commit 4684befc2583d861040ef138d2c3ff81b14af1eb
diff --git a/internal/compiler/analyze.go b/internal/compiler/analyze.go
@@ -58,6 +58,8 @@ func combineAnalysis(prev *analysis, a *analyzer.Analysis) *analysis {
 	if len(prev.Columns) == len(cols) {
 		for i := range prev.Columns {
 			prev.Columns[i].DataType = cols[i].DataType
+			prev.Columns[i].IsArray = cols[i].IsArray
+			prev.Columns[i].ArrayDims = cols[i].ArrayDims
 		}
 	} else {
 		embedding := false
@@ -73,6 +75,8 @@ func combineAnalysis(prev *analysis, a *analyzer.Analysis) *analysis {
 	if len(prev.Parameters) == len(params) {
 		for i := range prev.Parameters {
 			prev.Parameters[i].Column.DataType = params[i].Column.DataType
+			prev.Parameters[i].Column.IsArray = params[i].Column.IsArray
+			prev.Parameters[i].Column.ArrayDims = params[i].Column.ArrayDims
 		}
 	} else {
 		prev.Parameters = params

diff --git a/internal/endtoend/testdata/update_array_index/issue.md b/internal/endtoend/testdata/update_array_index/issue.md
@@ -0,0 +1 @@
+https://github.com/sqlc-dev/sqlc/issues/1532
diff --git a/internal/endtoend/testdata/update_array_index/postgresql/pgx/exec.json b/internal/endtoend/testdata/update_array_index/postgresql/pgx/exec.json
@@ -0,0 +1,3 @@
+{
+  "contexts": ["managed-db"]
+}
diff --git a/internal/endtoend/testdata/update_array_index/postgresql/pgx/go/db.go b/internal/endtoend/testdata/update_array_index/postgresql/pgx/go/db.go
diff --git a/internal/endtoend/testdata/update_array_index/postgresql/pgx/go/models.go b/internal/endtoend/testdata/update_array_index/postgresql/pgx/go/models.go
diff --git a/internal/endtoend/testdata/update_array_index/postgresql/pgx/go/query.sql.go b/internal/endtoend/testdata/update_array_index/postgresql/pgx/go/query.sql.go
diff --git a/internal/endtoend/testdata/update_array_index/postgresql/pgx/query.sql b/internal/endtoend/testdata/update_array_index/postgresql/pgx/query.sql
@@ -0,0 +1,5 @@
+-- name: UpdateAuthor :one
+update authors
+set names[$1] = $2
+where id=$3
+RETURNING *;
diff --git a/internal/endtoend/testdata/update_array_index/postgresql/pgx/schema.sql b/internal/endtoend/testdata/update_array_index/postgresql/pgx/schema.sql
@@ -0,0 +1,4 @@
+CREATE TABLE authors (
+  id    BIGSERIAL PRIMARY KEY,
+  names text[]    NOT NULL
+);
diff --git a/internal/endtoend/testdata/update_array_index/postgresql/pgx/sqlc.yaml b/internal/endtoend/testdata/update_array_index/postgresql/pgx/sqlc.yaml
@@ -0,0 +1,14 @@
+version: "2"
+cloud:
+  project: "01HAQMMECEYQYKFJN8MP16QC41"
+sql:
+  - engine: "postgresql"
+    schema: "schema.sql"
+    queries: "query.sql"
+    gen:
+      go:
+        package: "querytest"
+        out: "go"
+        sql_package: "pgx/v5"
+    database:
+      managed: true