Skip to content

fix(postgresql): Remove temporary pool config #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewmbenton merged 1 commit into from
Oct 13, 2023
Merged

fix(postgresql): Remove temporary pool config #2851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(postgresql): Remove temporary pool config 
The connection pool config was there before I was closing the pool after
analysis. The short connection lifespan was causing connection churn.
  • Loading branch information
@kyleconroy
kyleconroy committed Oct 13, 2023
commit 56d7d6f04070210ec6ab46bc8e4cf94bba78ca91
4 changes: 0 additions & 4 deletions internal/engine/postgresql/analyzer/analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"fmt"
"strings"
"sync"
"time"

"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgconn"
Expand Down Expand Up @@ -213,9 +212,6 @@ func (a *Analyzer) Analyze(ctx context.Context, n ast.Node, query string, migrat
if err != nil {
return nil, err
}
conf.MaxConns = 2
conf.MinConns = 0
conf.MaxConnLifetime = time.Second * 1
pool, err := pgxpool.NewWithConfig(ctx, conf)
if err != nil {
return nil, err
Expand Down