Skip to content

fix(compiler): Account for parameters without parents #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 2 commits into from
Oct 12, 2023
Merged

fix(compiler): Account for parameters without parents #2844

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a1f293
fix(compiler): Account for parameters without parents
kyleconroy Oct 12, 2023
1187ea0
mark those parameters as nullable
kyleconroy Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
mark those parameters as nullable
  • Loading branch information
@kyleconroy
kyleconroy committed Oct 12, 2023
commit 1187ea017f75ebf0202f722d7598ed8118504ac8
2 changes: 1 addition & 1 deletion internal/compiler/resolve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,

default:
slog.Debug("unsupported reference type", "type", fmt.Sprintf("%T", n))
defaultP := named.NewInferredParam(ref.name, true)
defaultP := named.NewInferredParam(ref.name, false)
p, isNamed := params.FetchMerge(ref.ref.Number, defaultP)
a = append(a, Parameter{
Number: ref.ref.Number,
Expand Down