Skip to content

refactor(codegen): remove golang and json settings from plugin proto #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewmbenton merged 4 commits into from
Oct 11, 2023
Merged

refactor(codegen): remove golang and json settings from plugin proto #2822

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f851620
refactor(codegen): remove golang and json settings from plugin proto
andrewmbenton Oct 11, 2023
a7345e8
clean up proto
andrewmbenton Oct 11, 2023
1adc44b
update sqlc-gen-json tests
andrewmbenton Oct 11, 2023
cd6cebc
put json plugin settings in `PluginOptions`
andrewmbenton Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up proto
  • Loading branch information
@andrewmbenton
andrewmbenton committed Oct 11, 2023
commit a7345e81743746d2eac3f5c3876c2acd83ed0a55
9 changes: 3 additions & 6 deletions protos/plugin/codegen.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ message ParsedGoType {
message Settings {
// PythonCode message was field 8
// KotlinCode message was field 9
reserved 8, 9;
// GoCode message was field 10;
// JSONCode message was field 11;
reserved 8, 9, 10, 11;

string version = 1 [json_name = "version"];
string engine = 2 [json_name = "engine"];
Expand All @@ -55,11 +57,6 @@ message Settings {
map<string, string> rename = 5 [json_name = "rename"];
repeated Override overrides = 6 [json_name = "overrides"];
Codegen codegen = 12 [json_name = "codegen"];

// TODO: Refactor codegen settings
// GoCode go = 10;
// JSONCode json = 11;
reserved 10, 11;
}

message Codegen {
Expand Down