Skip to content

test(endtoend): Split shema and queries #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 3 commits into from
Oct 4, 2023
Merged

test(endtoend): Split shema and queries #2803

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5204c4
test(endtoend): Split schema and queries
kyleconroy Oct 4, 2023
928d306
Remove workaround from ddl_test.go
kyleconroy Oct 4, 2023
a0e4a05
Fix more tests
kyleconroy Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove workaround from ddl_test.go
  • Loading branch information
@kyleconroy
kyleconroy committed Oct 4, 2023
commit 928d30633abed8fd97dfccd0e1b6c5ef1c2568c8
5 changes: 1 addition & 4 deletions internal/endtoend/ddl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,8 @@ func TestValidSchema(t *testing.T) {
if err != nil {
t.Fatalf("%s: %s", f, err)
}
// TODO: Split schema into separate files
before, _, _ := strings.Cut(string(contents), "-- name:")
before, _, _ = strings.Cut(before, "/* name:")
// Support loading pg_dump SQL files
before = strings.ReplaceAll(before, "CREATE SCHEMA public;", "CREATE SCHEMA IF NOT EXISTS public;")
before := strings.ReplaceAll(string(contents), "CREATE SCHEMA public;", "CREATE SCHEMA IF NOT EXISTS public;")
sqls = append(sqls, migrations.RemoveRollbackStatements(before))
}

Expand Down