Skip to content

feat(vet): Run rules against a managed database #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 8 commits into from
Sep 22, 2023
Merged

feat(vet): Run rules against a managed database #2751

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d8d73d
feat(vet): Support managed databases
kyleconroy Sep 21, 2023
8dfde57
feat(vet): Run rules against a managed database
kyleconroy Sep 21, 2023
c20dc5a
remove skip
kyleconroy Sep 21, 2023
e27afd3
fix read file error
kyleconroy Sep 21, 2023
e8812d8
Add managed to JSON schema
kyleconroy Sep 21, 2023
a3aa231
Use different hostname for region discovery
kyleconroy Sep 21, 2023
d12a8a6
Add first pass at docs
kyleconroy Sep 22, 2023
ffaf99e
docs: second pass at managed-databases.md
andrewmbenton Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix read file error
  • Loading branch information
@kyleconroy
kyleconroy committed Sep 21, 2023
commit e27afd343264b52d8b38d9ffcaf734c9a3f875ab
7 changes: 6 additions & 1 deletion internal/cmd/vet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"github.com/sqlc-dev/sqlc/internal/quickdb"
pb "github.com/sqlc-dev/sqlc/internal/quickdb/v1"
"github.com/sqlc-dev/sqlc/internal/shfmt"
"github.com/sqlc-dev/sqlc/internal/sql/sqlpath"
"github.com/sqlc-dev/sqlc/internal/vet"
)

Expand Down Expand Up @@ -407,7 +408,11 @@ func (c *checker) fetchDatabaseUri(ctx context.Context, s config.SQL) (string, f
}

var migrations []string
for _, query := range s.Schema {
files, err := sqlpath.Glob(s.Schema)
if err != nil {
return "", cleanup, err
}
for _, query := range files {
contents, err := os.ReadFile(query)
if err != nil {
return "", cleanup, fmt.Errorf("read file: %w", err)
Expand Down