Skip to content

test(examples): Use a hosted database for example testing #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 5 commits into from
Sep 20, 2023
Merged

test(examples): Use a hosted database for example testing #2749

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dcca77
test(examples): Use a hosted database for example testing
kyleconroy Sep 20, 2023
335aca7
deleted somthing but it should be the same
kyleconroy Sep 20, 2023
b7fc692
Remove logging
kyleconroy Sep 20, 2023
7b77ee0
Re-enable CI PostgreSQL
kyleconroy Sep 20, 2023
b28f02e
Fix pg_dump tests
kyleconroy Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove logging
  • Loading branch information
@kyleconroy
kyleconroy committed Sep 20, 2023
commit b7fc69273dfb7fd865a63afe3503192b2064731c
4 changes: 0 additions & 4 deletions internal/endtoend/ddl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"path/filepath"
"strings"
"testing"
"time"

"github.com/jackc/pgx/v5"

Expand All @@ -24,7 +23,6 @@ func TestValidSchema(t *testing.T) {

projectID := os.Getenv("CI_SQLC_PROJECT_ID")
authToken := os.Getenv("CI_SQLC_AUTH_TOKEN")

if projectID == "" || authToken == "" {
if os.Getenv("CI") == "" {
t.Skip("skiping ddl tests outside of CI")
Expand Down Expand Up @@ -102,13 +100,11 @@ func TestValidSchema(t *testing.T) {
sqls = append(sqls, migrations.RemoveRollbackStatements(before))
}

start := time.Now()
resp, err := client.CreateEphemeralDatabase(ctx, &pb.CreateEphemeralDatabaseRequest{
Engine: "postgresql",
Region: "iad",
Migrations: sqls,
})
t.Logf("%s", time.Since(start))
if err != nil {
t.Fatal(err)
}
Expand Down