fix(codegen/golang): Fix detection of querier used packages #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@pespantelis Could you build sqlc from main and verify that this has been fixed? |
Author
|
@kyleconroy Yep, it works for my case. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! First of all, I want to drop a quick thank you for this awesome project, it's a blast working with it!
After the
v1.21.0release, I noticed that thequerier.gofile imports thetimepackage, without any reference on that package.This PR addresses the issue, but since I'm relatively new to this project, I'm not entirely certain if it's the ideal solution. Your feedback and guidance would be greatly appreciated!
Fixes #2707