Skip to content

Keep environment variables on calling plugin #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
walterwanderley wants to merge 1 commit into from
Closed

Keep environment variables on calling plugin #2661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: keep environment variables on calling plugin
  • Loading branch information
@walterwanderley
walterwanderley committed Aug 26, 2023
commit f724071d8cd4a71091d9e6dadf170cefa187a8ca
5 changes: 2 additions & 3 deletions internal/ext/process/gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"context"
"errors"
"fmt"
"os"
"os/exec"

"google.golang.org/protobuf/proto"
Expand All @@ -31,9 +32,7 @@ func (r Runner) Generate(ctx context.Context, req *plugin.CodeGenRequest) (*plug

cmd := exec.CommandContext(ctx, path)
cmd.Stdin = bytes.NewReader(stdin)
cmd.Env = []string{
fmt.Sprintf("SQLC_VERSION=%s", req.SqlcVersion),
}
cmd.Env = append(os.Environ(), fmt.Sprintf("SQLC_VERSION=%s", req.SqlcVersion))

out, err := cmd.Output()
if err != nil {
Expand Down