Skip to content

refactor(astutils): remove redundant nil check in Walk #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 1 commit into from
Aug 28, 2023
Merged

refactor(astutils): remove redundant nil check in Walk #2660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(astutils): remove redundant nil check in Walk 
From the Go docs:

  "For a nil slice, the number of iterations is 0." [1]

Therefore, an additional nil check for before the loop is unnecessary.

[1]: https://go.dev/ref/spec#For_range

Signed-off-by: Eng Zer Jun <[email protected]>
  • Loading branch information
@Juneezee
Juneezee committed Aug 26, 2023
commit 5df291ec55525e94adb77d2fde05fd83a5530d7d
6 changes: 2 additions & 4 deletions internal/sql/astutils/walk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2158,10 +2158,8 @@ func Walk(f Visitor, node ast.Node) {
}

case *ast.In:
if n.List != nil {
for _, l := range n.List {
Walk(f, l)
}
for _, l := range n.List {
Walk(f, l)
}
if n.Sel != nil {
Walk(f, n.Sel)
Expand Down