Skip to content

All not needed an alias when there is a subquery with the same column name #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ovadbar wants to merge 3 commits into from
Closed

All not needed an alias when there is a subquery with the same column name #2639

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34c1a54
Separate the scope of tables to allow removal of aliases
Aug 20, 2023
6361797
Remove duplicate additions of tables
Aug 20, 2023
5d171a0
remove comment
Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove comment
  • Loading branch information
Baroukh Ovadia committed Aug 20, 2023
commit 5d171a018fe7605811034e5ef9e4b89d174ccb1b
1 change: 0 additions & 1 deletion internal/compiler/resolve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,6 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, args []paramRef, para
}
}
if found > 1 {
fmt.Println("ambiguous 3")
return nil, &sqlerr.Error{
Code: "42703",
Message: fmt.Sprintf("column reference %q is ambiguous", key),
Expand Down