Skip to content

fix(engine/dolphin): Fixed problem that LIMIT OFFSET cannot be used with UNION ALL #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 2 commits into from
Aug 28, 2023
Merged

fix(engine/dolphin): Fixed problem that LIMIT OFFSET cannot be used with UNION ALL #2613

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e2c69e
fix(engine/dolphin): Fixed problem that LIMIT OFFSET cannot be used w…
orisano Aug 14, 2023
83c0668
test: update endtoend
orisano Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(engine/dolphin): Fixed problem that LIMIT OFFSET cannot be used w… 
…ith `UNION ALL`

close #2611
  • Loading branch information
@orisano
orisano committed Aug 14, 2023
commit 2e2c69e1141ae14844a524fd8bcd507f54059ce6
7 changes: 6 additions & 1 deletion internal/engine/dolphin/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,12 @@ func (c *cc) convertSetOprSelectList(n *pcast.SetOprSelectList) ast.Node {

func (c *cc) convertSetOprStmt(n *pcast.SetOprStmt) ast.Node {
if n.SelectList != nil {
return c.convertSetOprSelectList(n.SelectList)
sn := c.convertSetOprSelectList(n.SelectList)
if ss, ok := sn.(*ast.SelectStmt); ok && n.Limit != nil {
ss.LimitOffset = c.convert(n.Limit.Offset)
ss.LimitCount = c.convert(n.Limit.Count)
}
return sn
}
return todo(n)
}
Expand Down