fix(engine/sqlite): fixed detection of column alias without AS #2560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
requested changes
Aug 2, 2023
Collaborator
kyleconroy
left a comment
kyleconroy
left a comment
There was a problem hiding this comment.
For end-to-end tests, the query should be consistent across engines. In this particular case, either create a new end-to-end test or create a second named query in query.sql, adding it to the MySQL and PostgreSQL test cases as well.
Contributor
Author
|
@kyleconroy fixed! |
Collaborator
|
I think this will need a rebase or merge from main to get tests running again. |
Contributor
Author
|
@andrewmbenton rebased! |
Collaborator
|
Looks good to me. @kyleconroy do these tests look alright? |
kyleconroy
approved these changes
Aug 2, 2023
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
…dev#2560) * fix(engine/sqlite): fixed detection of column alias without AS fix sqlc-dev#2559 * test: update endtoend * test: update endtoend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2559