Allow for DDL and unsupported statements as a query

By adding 'no-inference' to your query comment, sqlc won't try to understand your query. (The dolphin/postgresql parser still need to understand your syntax.) This means that params and output columns don't work, but you can run any query you want.
sqlc-dev · Jille · Jun 25, 2023 · Jun 28, 2023 · Jun 28, 2023 · Jun 28, 2023
commit 7c18712d0bc1eef792e0cd097f83ac01eaaa0105
diff --git a/internal/compiler/parse.go b/internal/compiler/parse.go
@@ -23,17 +23,43 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
 	if o.Debug.DumpAST {
 		debug.Dump(stmt)
 	}
+	raw, ok := stmt.(*ast.RawStmt)
+	if !ok {
+		return nil, errors.New("node is not a statement")
+	}
+	rawSQL, err := source.Pluck(src, raw.StmtLocation, raw.StmtLen)
+	if err != nil {
+		return nil, err
+	}
+	if rawSQL == "" {
+		return nil, errors.New("missing semicolon at end of file")
+	}
+	name, cmd, cmdParams, err := metadata.Parse(strings.TrimSpace(rawSQL), c.parser.CommentSyntax())
+	if err != nil {
+		return nil, err
+	}
+	if cmdParams.NoInference {
+		trimmed, comments, err := source.StripComments(rawSQL)
+		if err != nil {
+			return nil, err
+		}
+		return &Query{
+			Cmd:       cmd,
+			Comments:  comments,
+			Name:      name,
+			Params:    nil,
+			Columns:   nil,
+			SQL:       trimmed,
+			CmdParams: cmdParams,
+		}, nil
+	}
 	if err := validate.ParamStyle(stmt); err != nil {
 		return nil, err
 	}
 	numbers, dollar, err := validate.ParamRef(stmt)
 	if err != nil {
 		return nil, err
 	}
-	raw, ok := stmt.(*ast.RawStmt)
-	if !ok {
-		return nil, errors.New("node is not a statement")
-	}
 	var table *ast.TableName
 	switch n := raw.Stmt.(type) {
 	case *ast.CallStmt:
@@ -57,23 +83,12 @@ func (c *Compiler) parseQuery(stmt ast.Node, src string, o opts.Parser) (*Query,
 		return nil, ErrUnsupportedStatementType
 	}
 
-	rawSQL, err := source.Pluck(src, raw.StmtLocation, raw.StmtLen)
-	if err != nil {
-		return nil, err
-	}
-	if rawSQL == "" {
-		return nil, errors.New("missing semicolon at end of file")
-	}
 	if err := validate.FuncCall(c.catalog, c.combo, raw); err != nil {
 		return nil, err
 	}
 	if err := validate.In(c.catalog, raw); err != nil {
 		return nil, err
 	}
-	name, cmd, cmdParams, err := metadata.Parse(strings.TrimSpace(rawSQL), c.parser.CommentSyntax())
-	if err != nil {
-		return nil, err
-	}
 	raw, namedParams, edits := rewrite.NamedParameters(c.conf.Engine, raw, numbers, dollar)
 	if err := validate.Cmd(raw.Stmt, name, cmd); err != nil {
 		return nil, err

diff --git a/internal/endtoend/testdata/no_inference/postgresql/go/db.go b/internal/endtoend/testdata/no_inference/postgresql/go/db.go
diff --git a/internal/endtoend/testdata/no_inference/postgresql/go/models.go b/internal/endtoend/testdata/no_inference/postgresql/go/models.go
diff --git a/internal/endtoend/testdata/no_inference/postgresql/go/query.sql.go b/internal/endtoend/testdata/no_inference/postgresql/go/query.sql.go
diff --git a/internal/endtoend/testdata/no_inference/postgresql/query.sql b/internal/endtoend/testdata/no_inference/postgresql/query.sql
@@ -0,0 +1,2 @@
+-- name: CreateTempTable :exec no-inference
+CREATE TEMPORARY TABLE bar (LIKE foo);
diff --git a/internal/endtoend/testdata/no_inference/postgresql/schema.sql b/internal/endtoend/testdata/no_inference/postgresql/schema.sql
@@ -0,0 +1 @@
+CREATE TABLE foo (val text not null);
diff --git a/internal/endtoend/testdata/no_inference/postgresql/sqlc.json b/internal/endtoend/testdata/no_inference/postgresql/sqlc.json
@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "engine": "postgresql",
+      "path": "go",
+      "name": "querytest",
+      "schema": "schema.sql",
+      "queries": "query.sql"
+    }
+  ]
+}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		-- name: CreateTempTable :exec no-inference
		CREATE TEMPORARY TABLE bar (LIKE foo);