Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I believe this is Python 2 code and can be safely removed. correct? #243

Open
jvanasco opened this issue Oct 1, 2023 · 2 comments
Open

I believe this is Python 2 code and can be safely removed. correct? #243

jvanasco opened this issue Oct 1, 2023 · 2 comments

Comments

@jvanasco
Copy link
Member

jvanasco commented Oct 1, 2023

dogpile.cache/dogpile/cache/backends/redis.py

Line 9 in fa090be

from __future__ import absolute_import

i will generate the PR if someone can confirm
@zzzeek
Copy link
Member

zzzeek commented Oct 1, 2023

yes that is python 2 only, absolute_imports are standard in python 3

@jvanasco jvanasco mentioned this issue Oct 1, 2023
Closed
@jvanasco
Copy link
Member Author

jvanasco commented Oct 1, 2023

That's what I thought, but it was weird seeing it so I second-guessed myself.

PR is in #244

sqlalchemy-bot pushed a commit that referenced this issue Oct 1, 2023
@jvanasco
removed legacy py2 __future__ directive
221c6fe 
see #243

Closes: #244
Pull-request: #244
Pull-request-sha: 84ec326

Change-Id: I89508db5f8ee4b634e4b70ea22bf11fc47fb08b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zzzeek @jvanasco