Add Support GenerateOneTimeTokenRequestResolver #16297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
franticticktick
force-pushed
the
gh-16291
branch
from
714b2c4 to
6d330d7
Compare
rwinch
added
in: web
rwinch
requested changes
Jan 21, 2025
| * @param username username | ||
| * @param expiresIn one-time token expiration time (seconds) | ||
| */ | ||
| public GenerateOneTimeTokenRequest(String username, int expiresIn) { |
There was a problem hiding this comment.
Please change expiresIn to a Duration
...ingframework/security/web/authentication/ott/DefaultGenerateOneTimeTokenRequestResolver.java
Outdated
Show resolved
Hide resolved
|
|
||
| private static final int DEFAULT_EXPIRES_IN = 300; | ||
|
|
||
| private int expiresIn = DEFAULT_EXPIRES_IN; |
There was a problem hiding this comment.
Please change this to a Duration
...ingframework/security/web/authentication/ott/DefaultGenerateOneTimeTokenRequestResolver.java
Outdated
Show resolved
Hide resolved
...amework/security/config/annotation/web/configurers/ott/OneTimeTokenLoginConfigurerTests.java
Show resolved
Hide resolved
...c/main/java/org/springframework/security/authentication/ott/GenerateOneTimeTokenRequest.java
Outdated
Show resolved
Hide resolved
| private final String username; | ||
|
|
||
| private final int expiresIn; |
There was a problem hiding this comment.
Please change this to a Duration
...c/main/java/org/springframework/security/authentication/ott/GenerateOneTimeTokenRequest.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/authentication/ott/GenerateOneTimeTokenRequest.java
Outdated
Show resolved
Hide resolved
franticticktick
force-pushed
the
gh-16291
branch
from
6d330d7 to
dedf366
Compare
|
@rwinch thanks for feedback, all your comments have been resolved. |
rwinch
requested changes
Jan 21, 2025
franticticktick
force-pushed
the
gh-16291
branch
2 times, most recently
from
a5cdaae to
0dba7d6
Compare
Closes spring-projectsgh-16291 Signed-off-by: Max Batischev <[email protected]>
franticticktick
force-pushed
the
gh-16291
branch
from
0dba7d6 to
a879f76
Compare
|
Added documentation, @rwinch done :) |
rwinch
approved these changes
Jan 22, 2025
|
Thanks for the PR and your quick attention to changes! This is now merged into main 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16291