feat(expense-list): Display the attachment count only when the expense includes attachments #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is great @yuvarajsai, thanks a lot! I updated two things on your PR:
|
Contributor
Author
|
This is my first open source PR and glad that you appreciate it @scastiel 🙌 Please feel free to assign any issues in this or spliit-mobile repo. I really appreciate the idea of "spliit" being an open-source project. Thank you for this initiative and your efforts. |
Lipkin10
pushed a commit
to Lipkin10/Split-AI-first-version
that referenced
this pull request
Jul 30, 2025
…e includes attachments (spliit-app#267) * feat(expense-list): Display the attachment count only when the expense includes attachments * handle attachments - singular & plural * move documents count between amount and date * Remove label * Use document count only instead of whole document list --------- Co-authored-by: Sebastien Castiel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have attachments for expenses, but in expenses list we do not show if a particular expense has an attachment or not. Relates to #238
Before:
After:
Expense has attachments:
Mobile:
No attachments: