Allow PORT to be specified when using bin/dev
#5949
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would force the development server to run on 3000, but it is useful to be able to override that. Co-authored-by: Harmony Evangelina <[email protected]>
github-actions
bot
added
the
changelog:repository
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5949 +/- ##
==========================================
- Coverage 89.54% 89.45% -0.09%
==========================================
Files 782 782
Lines 17997 17997
==========================================
- Hits 16116 16100 -16
- Misses 1881 1897 +16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jarednorman
approved these changes
Nov 21, 2024
kennyadsl
approved these changes
Nov 21, 2024
|
sank ju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a small quality of life improvement when running the development
server through the
bin/devbinstub.Previously running
bin/devwould force the development server to run on port3000, but it is useful to be able to override that if you are running multiple
projects and want to also run the Solidus sandbox app.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: