Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4] Backend Menu: Fix "Promotions" items #5924

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.4:

Questions ?

Please refer to the Backport tool documentation

Prior to this commit, legacy promotions would be called "Promotions",
but if `solidus_promotions` is installed, they would be called "Legacy
Promotions" in the menu. It's much easier if each of the two promotion
engines just inserts its own menu item into the menu, and the legacy
promotion system is called "Legacy Promotions" from the get-go.

Co-Authored-By: [email protected]
(cherry picked from commit 6a7d839)
@github-actions github-actions bot requested a review from a team as a code owner November 14, 2024 16:33
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Nov 14, 2024
@tvdeyen tvdeyen merged commit 9fc4941 into v4.4 Nov 14, 2024
@tvdeyen tvdeyen deleted the backport/v4.4/pr-5921 branch November 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant