feat: handle non 2xx responses in GAF network stack #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinSnyk
commented
Nov 27, 2024
CatalinSnyk
commented
Nov 27, 2024
CatalinSnyk
force-pushed
the
feat/handle-non-2xx-response-CLI-575
branch
2 times, most recently
from
2c1fb80 to
32078b4
Compare
Previously, the call for fetching the SAST enabled setting from the Snyk API was done in the initialization of the Code workflow. If the call failed because of an error (be it an auth error or any other kind), the workflow would still return an error to enable Snyk Code. To fix this, the network call has been moved in the entrypoint for the workflow, and if an error happens during the request, it is returned back from the workflow.
Changed the DefaultValueFunction type to return an error which can be retrieved using the new GetE getter. Related: CLI-608, CLI-611
PeterSchafer
force-pushed
the
feat/handle-non-2xx-response-CLI-575
branch
from
1f378b6 to
2692805
Compare
PeterSchafer
reviewed
Dec 4, 2024
PeterSchafer
reviewed
Dec 4, 2024
PeterSchafer
reviewed
Dec 9, 2024
PeterSchafer
reviewed
Dec 9, 2024
PeterSchafer
reviewed
Dec 9, 2024
PeterSchafer
reviewed
Dec 9, 2024
Contributor
|
Looks really great, Thank you! I only left some minor comments. |
PeterSchafer
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CLI-575