chore: make configuration thread-safe #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
changed the title
Member
|
@PeterSchafer are there tests we can introduce which verify the desired behaviour which is enabled through the use of RWMutex are available? I am guessing that would be multiple goroutines can hold read locks simultaneously. |
PeterSchafer
force-pushed
the
chore/config_rwmutex
branch
from
7ec3636 to
6bd1bf0
Compare
thisislawatts
approved these changes
Dec 2, 2024
PeterSchafer
force-pushed
the
chore/config_rwmutex
branch
from
6526210 to
250220d
Compare
PeterSchafer
force-pushed
the
chore/config_rwmutex
branch
from
250220d to
744fe28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the locking in the Configuration and improves it by using an RWMutex.