feat: modify auth token url based on instance param #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmars
force-pushed
the
feat/redirect-with-instance-param
branch
4 times, most recently
from
26d7b95 to
345bc9e
Compare
ShawkyZ
reviewed
Oct 10, 2024
thisislawatts
force-pushed
the
feat/redirect-with-instance-param
branch
6 times, most recently
from
f6cfded to
8323cb4
Compare
Snyk's OAuth implementation is capable of indicating the environment
which the user is authenticated into and authorized to access.
This is specified in the audience JWT claim ("aud"). Snyk's
implementation of this claim contains an array of strings, per RFC 7519.
If set and non-empty, the first audience URL is taken as the default API
URL that the client should use, unless the endpoint was specifically
configured.
It's a test JWT created on jwt.io for testing the parsing of claims and cannot be used as a valid authorization anywhere.
If an instance parameter is provided in the redirect, use it to modify the URL from where the oauth token is obtained. The instance provided is the Snyk region domain, minus the api. host prefix.
* test hygiene * reduce size of authenticateWithAuthorizationCode
thisislawatts
approved these changes
Nov 29, 2024
PeterSchafer
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an instance parameter is provided in the redirect, use it to modify
the URL from where the oauth token is obtained.
The instance provided is the Snyk region domain, minus the api. host
prefix.
Stacked on #258