fix: introduce additional fall back if the user cache directory can't be used #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
changed the title
PeterSchafer
force-pushed
the
fix/CLI-409_improved_cachedir_usage
branch
from
3921713 to
fccff04
Compare
sandor-trombitas
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an additional fallback cache directory to increase fault tolerance of the Snyk CLI. When the first cache directory can't be used it'll try the tmp dir and later only the current dir.
This shall make the CLI function in environments that are very limited in their permissions.
Implementation detail:
I replaced a handwritten mock by a generated mock to easier test, which is why there are a couple of changes in the tests.
Risk: There is a rick that this change of behaviour could cause problems for certain customers the limit strongly from where applications can be executed. Since the primary folder doesn't change and just the first fallback changes, the risk is probably small. Also the last fallback will be as before.
Related Tickets: CLI-409, CLI-576