Add collector to target latency metrics #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In common-streams 0.8.x we shifted alerting / retrying / webhook out of the applications and into the common library. It also adds new features like heartbeat webhooks starting when the loader first becomes healthy. This commit also makes the webhook alert messages more human-friendly.
oguzhanunlu
force-pushed
the
latency-sla
branch
4 times, most recently
from
8aa692a
to
68bcdc0
Compare
oguzhanunlu
force-pushed
the
latency-sla
branch
from
68bcdc0
to
d26696d
Compare
modules/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/Metrics.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/Metrics.scala
Show resolved
Hide resolved
...les/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/processing/Processing.scala
Outdated
Show resolved
Hide resolved
colmsnowplow
approved these changes
Oct 18, 2024
Compared to common-streams 0.8.0-M2, this version adds: - Re-implemented Kinesis source without fs2-kinesis - Pubsub source opens more transport channels when necessary - Changes default webhook heartbeat period to 5 minutes - Http4s Client with configuration appropriate for common-streams apps Other changes to common-streams are not relevant for snowflake loader, so not mentioned here.
This version holds onto a map of batches that are in memory but not yet loaded. This means we can report latency of in-memory batches under all of the following circumstances: - Loader is doing long backoff and retry due to snowflake setup issue (e.g. expired password) - Loader is stuck trying to open a connection to snowflake due to a transient network issue - Loader is trying to shutdown due to any other runtime exception
oguzhanunlu
force-pushed
the
latency-sla
branch
from
79faf88
to
b131b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1495
This PR adds 2 metrics
latency_collector_to_target_millis: the minimum latency of all batches in the current metric period, where latency of a batch is computed as {load time - max collector_tstamp of the batch}latency_collector_to_target_pessimistic_millis: the maximum latency of all batches in the current metric period, where latency of a batch is computed as {report time - min collector_tstamp of the batch}