Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluesky edits aren't visible (blocked on bsky.app) #947

Open
snarfed opened this issue Apr 10, 2024 · 8 comments
Open

Bluesky edits aren't visible (blocked on bsky.app) #947

snarfed opened this issue Apr 10, 2024 · 8 comments
Labels

Comments

@snarfed
Copy link
Owner

snarfed commented Apr 10, 2024

https://bsky.app/profile/snarfed.org.web.brid.gy/post/3kps4z7ve6hg2 is federated from https://snarfed.org/2024-04-10_52782 . I originally posted (and federated) it without u-photo, so the image didn't appear in ATProto. I added u-photo and re-federated it, and the photo appeared in the fediverse, but not in Bluesky. Not sure if updates aren't working, or images, or both.

@snarfed
Copy link
Owner Author

snarfed commented May 1, 2024

This might be a bsky.app issue. I tried again with just a text post and edit, and atproto.tools shows both the create and the update as valid, https://atproto.tools/records?did=did%3Aplc%3Abg5udl25mvzg3rt7l5n2hzet&collection=app.bsky.feed.post&rkey=3krh65hkwbp42 , but bsky.app only shows the original create: https://bsky.app/profile/snarfed.indieweb.social.ap.brid.gy/post/3krh65hkwbp42

@snarfed
Copy link
Owner Author

snarfed commented May 1, 2024

^ if so, the answer here is probably to add this to the docs.

@snarfed
Copy link
Owner Author

snarfed commented May 1, 2024

(Oh and images have worked in original AP => ATProto posts, so it's an update thing.)

@snarfed snarfed changed the title Updates or images aren't working with ATProto Updates aren't working with ATProto May 1, 2024
@snarfed snarfed added the now label May 2, 2024
@snarfed snarfed changed the title Updates aren't working with ATProto Bluesky: updates aren't working (blocked on bsky.app) May 2, 2024
@snarfed snarfed changed the title Bluesky: updates aren't working (blocked on bsky.app) Bluesky: edits aren't working (blocked on bsky.app) May 2, 2024
snarfed added a commit that referenced this issue May 5, 2024
@snarfed
Copy link
Owner Author

snarfed commented May 5, 2024

Updated docs, will be visible at https://fed.brid.gy/docs#bluesky-edits soon.

@snarfed snarfed removed the now label May 5, 2024
@njlarsson
Copy link

I edited a reply twice in Mastodon. The first two versions got picked up as different replies in Bluesky, but the third and final version never appeared. I understand that I can’t expect editing to work properly, but I thought this was strange behavior that might be interesting. This is the reply I edited: https://mastodon.nu/@avadeaux/112469287039821443

@snarfed
Copy link
Owner Author

snarfed commented May 20, 2024

Whoa, that's definitely odd! Thanks for reporting, I see them both on https://bsky.app/profile/avadeaux.mastodon.nu.ap.brid.gy/post/3ksuc7mn4vhn2 . Will look.

@bnewbold
Copy link

Yeah, things will just be very janky in the Bluesky app around this until we properly implement post editing at the UI/UX level.

As you can tell, how to update a record is pretty clear. What we want to support is keeping the old versions of the record around in the repo in some way (eg, a repo path extension with the CID as another path segment), and then clarify/specify what the behaviors of things like a "reply to a previous version" or "liked a previous version" should be after an edit.

For now, you might find it more robust/functional to delete the record and then re-create it with the same rkey and overall AT-URI, in separate commits, instead of doing an "update" in a single commit? This is sort of just a stab in the dark.

@snarfed
Copy link
Owner Author

snarfed commented May 31, 2024

What we want to support is keeping the old versions of the record around in the repo in some way (eg, a repo path extension with the CID as another path segment), and then clarify/specify what the behaviors of things like a "reply to a previous version" or "liked a previous version" should be after an edit.

Oh man, true. prev is dead, long live prev, eh?

For now, you might find it more robust/functional to delete the record and then re-create it with the same rkey and overall AT-URI, in separate commits, instead of doing an "update" in a single commit? This is sort of just a stab in the dark.

Lol true! Good idea, like Mastodon's "delete and redraft" but under the covers. This isn't high priority for me right now, but if it bubbles up before you all figure this out on your end, I can definitely try this. Thanks!

@snarfed snarfed changed the title Bluesky: edits aren't working (blocked on bsky.app) Bluesky edits aren't visible (blocked on bsky.app) Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants