Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out a core library with fewer dependencies #107

Merged
merged 9 commits into from
Oct 1, 2021
Merged

Conversation

anka-213
Copy link
Collaborator

This is useful for the ghcjs stuff

@Martin-Strecker
Copy link
Contributor

Thanks! In principle, this looks reasonable to me. But I have a naive question concerning Git: will Git be able to recognize which files correspond so that changes made to a file (say, the parser) get correctly integrated in the split-to-packages branch, in spite of the different file structure?

@anka-213
Copy link
Collaborator Author

It should be able to do that, but as long as we merge it in quickly, there shouldn't be any merge conflicts even if it didn't. Unless you have unmerged changes in the parser?

@Martin-Strecker
Copy link
Contributor

I don't have any changes right now, but I just wonder for the future how we keep the split-to-packages repo in sync with the development (which, I assume, will continue in main, smtgen etc, unless we close these branches and start new branches from split-to-packages).

@anka-213
Copy link
Collaborator Author

We would migrate to only using the split version as soon as this is merged. We shouldn't have multiple long-running parallel branches running.

@anka-213
Copy link
Collaborator Author

In other words, this would be the new main that everything builds on top of.

@anka-213 anka-213 merged commit 1d5ad58 into main Oct 1, 2021
@kharus kharus deleted the split-to-packages branch February 10, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants