-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12 #33
base: master
Are you sure you want to change the base?
#12 #33
Conversation
Signed-off-by: Matthew Valimaki <[email protected]>
Signed-off-by: Matthew Valimaki <[email protected]>
Signed-off-by: Matthew Valimaki <[email protected]>
@matthewvalimaki, are you able to refactor this PR now that all the changes have been launched? I still think it's a worth while addition. |
@smebberson yes sir. I'll try to get it done asap.
|
@matthewvalimaki, I'm going to be making these changes while moving to Node.js v7. I'm going to be releasing all of the 6.x releases I've missed now. Are you willing to refactor this now as there has been a few changes, and then I'll merge this in. Thanks! |
@smebberson I am looking for a way operate within the container as non-root user. Since this PR seems outdated – can you recommend any best practices for now? /cc @GauSim |
nodejs
user and group.nodejs
user for execution.Signed-off-by: Matthew Valimaki [email protected]