Feat: Implement new role access #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Akalanka47000
requested changes
Sep 2, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Can we remove this and switch to pnpm
| > | ||
| Edit | ||
| </Button> | ||
| {localStorage.getItem("role") == "ADMIN" ? ( |
There was a problem hiding this comment.
Let's not rely on localstorage for this and use the profile from RTK Query
src/components/users/user/index.jsx
Outdated
| loading={isLoading} | ||
| loaderProps={{ width: 16, height: 16 }} | ||
| /> | ||
| {localStorage.getItem("role") == "ADMIN" ? ( |
There was a problem hiding this comment.
Let's not rely on localstorage for this and use the profile from RTK Query
src/store/api/auth.js
Outdated
| @@ -20,6 +20,7 @@ export const authApi = createApi({ | |||
| } else { | |||
| localStorage.setItem("access_token", response.data.access_token); | |||
| localStorage.setItem("refresh_token", response.data.refresh_token); | |||
| localStorage.setItem("role", response.data.user.role); | |||
There was a problem hiding this comment.
We don't need this, we already have the user info with us in the access token which also is used to retrieve and set to the state
Akalanka47000
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.