Implement an SST iterator #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgb
force-pushed
the
paulgb/sst-iterator
branch
from
dbc9abe
to
e3f3ff9
Compare
|
Yep, yep. This is great. Agreed that the page cache will probably get implemented inside of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prereq to #8, we need a way to iterate over an SST. This builds on top of the existing block iterator.
Since a
BlockIteratorholds a reference to aBlock, it needs to live for at least as long as the block. When iterating over an entire SST, the easiest way to do this is to have theBlockIteratorown the block. I opted here to create aBlockLiketrait which is implemented for bothBlockand&Block. I suspect that once we start caching reads, we will want to pass around reference-countedBlockvalues instead, but this approach lets us defer that discussion until later.