Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging.py #1567

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Logging.py #1567

merged 4 commits into from
Nov 29, 2024

Conversation

s-cork
Copy link
Contributor

@s-cork s-cork commented Nov 29, 2024

Adds logging support

mostly from the cpython library with some adaptions to skulpt

Not supported:

  • String templates style support
  • No error checking in string format style
  • No error handling support
  • No warning support
  • No file handler support
  • no logging.config module or logging.handlers module

adds sys.stderr - which is the same as sys.stdout

bnmnetp
bnmnetp approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@bnmnetp bnmnetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem very straightforward, and self contained. Very mergeable.

@s-cork s-cork merged commit 5a78943 into skulpt:master Nov 29, 2024
1 check passed
@s-cork s-cork deleted the logging branch November 29, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnmnetp bnmnetp bnmnetp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-cork @bnmnetp