Webpack upgrade #1526
Open
Webpack upgrade #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to use some of the latest features of javascript in skulpt
This PR does the minimum to upgrade to webpack 5
Unfortunately the webpack-closure-plugin does not officially support webpack 5
webpack-contrib/closure-webpack-plugin#161
And so to build skulpt you would now need to do
npm install --legacy-peer-deps(This might be a deal breaker for this PR)
Fortunately the
npm run buildworks just with some deprecation warnings from webpack