string interning: don't do it - rely on compiled constants #1481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
str interning for a long running python program could use a lot of memory
our current implementation is also not quite the same as cpython
Our constants are cached during compilation so tests that look for compiled str identity will still work
I actually didn't need to change any tests here.
I adjusted places where we rely on str identity in the code base
This reliance also meant implementing
tp$hash
forSk.builtin.str
(The python 2.7 implementation is much easier to follow so I used that)
I adjusted the internals of
$name
forSk.builtin.func
to be a python string.There was a test for this in
test_functools
that expected__name__
to be identical after wrapping