Ensure we fail if a offer is not found for RemoveOfferOperation.

Otherwise we end up panicing later on a nil pointer.
sinanawad · Mar 14, 2022 · bab28b2 · bab28b2
1 parent eb7d9fd
commit bab28b2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/state/applicationoffers.go b/state/applicationoffers.go
@@ -161,7 +161,7 @@ func (s *applicationOffers) RemoveOfferOperation(offerName string, force bool) (
 
 	// Any proxies for applications on the consuming side also need to be removed.
 	offer, err := offerStore.ApplicationOffer(offerName)
-	if err != nil && !errors.IsNotFound(err) {
+	if err != nil {
 		return nil, errors.Trace(err)
 	}
 	var associatedAppProxies []*DestroyRemoteApplicationOperation