Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for logs #2039

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Metrics for logs #2039

merged 6 commits into from
Jan 10, 2025

Conversation

sonamgupta21
Copy link
Collaborator

Description

Added few additional metrics

  • event count per minute
  • event volume per minute
  • number of indexes
  • total segment count
  • total column count
  • total CMI size
  • total CSG size
  • Number of files (per index; key=indexName, value=(e.g., ind-0))
  • Number of blocks (per index)

Fixes # (link all the GitHub issues this addresses)

Testing

Describe how you tested this code. How can the reviewers reproduce your tests?

Checklist:

Before marking your pull request as ready for review, complete the following.

  • I have self-reviewed this PR.
  • I have removed all print-debugging and commented-out code that should not be merged.
  • I have added sufficient comments in my code, particularly in hard-to-understand areas.
  • I have formatted the code, if applicable. For Go, I have run goimports -w ..

Copy link
Collaborator

@AndrewHess AndrewHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good; just a few nits

pkg/ingest/ingestionStats.go Outdated Show resolved Hide resolved
pkg/instrumentation/ssgauges.go Outdated Show resolved Hide resolved
@AndrewHess AndrewHess enabled auto-merge (squash) January 10, 2025 15:16
@AndrewHess AndrewHess merged commit ff0ccc8 into siglens:develop Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants