Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused configs #2037

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Conversation

sonamgupta21
Copy link
Collaborator

Description

  1. Remove EventTypeKeywords config as it is not utilized now.
  2. Fix typo TRACE_SAMPLING_PRECENTAGE to TRACE_SAMPLING_PERCENTAGE
  3. Rename config maxOpenColumns to maxAllowedColumns

Fixes # (link all the GitHub issues this addresses)

Testing

Describe how you tested this code. How can the reviewers reproduce your tests?

Checklist:

Before marking your pull request as ready for review, complete the following.

  • I have self-reviewed this PR.
  • I have removed all print-debugging and commented-out code that should not be merged.
  • I have added sufficient comments in my code, particularly in hard-to-understand areas.
  • I have formatted the code, if applicable. For Go, I have run goimports -w ..

@AndrewHess AndrewHess enabled auto-merge (squash) January 10, 2025 16:57
@AndrewHess AndrewHess merged commit 92cfa47 into siglens:develop Jan 10, 2025
8 checks passed
@sonamgupta21 sonamgupta21 deleted the remove-unused-configs branch February 5, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants