Make created_at/enqueued_at storing integer milliseconds
#6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do the benchmarks look? |
|
Time benefit is the same as if using integers, but memory benefit is 2x worse than if using integers (for integers we will save 180mb in redis, but for milliseconds now 90mb). |
|
I switched the implementation to use: ::Process.clock_gettime(::Process::CLOCK_REALTIME, :millisecond)as it benchmarked as over 2x faster than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion #6562.
With this PR, sidekiq will now store created_at/enqueued_at timestamps as integer milliseconds since the epoch.
It will also currently accept timestamps in the old format (fractional seconds since the epoch) for existing jobs.