-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add functionality for plugin checksums #5362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will add the administration files, the changelog file and tests within the next few days. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #5362 +/- ##
===========================================
- Coverage 65.46% 43.83% -21.64%
===========================================
Files 3677 3081 -596
Lines 82789 87693 +4904
===========================================
- Hits 54201 38439 -15762
- Misses 28588 49254 +20666 ☔ View full report in Codecov by Sentry. |
Hey @M-arcus, what is the state of this PR? Are you currently working on it? In general we think this feature would be best served as an extension and not in the core framework, so if you do plan on continuing to work on it, please ping so we can discuss. We appreciate the effort and wouldn't want to disappoint any one involved, so we should communicate and make sure we are all on the same page! That does not mean we say no: but we should definitely discuss and weigh up the advantages/disadvantages of this living in the framework 😄 |
It is technically complete, but needs tests and admin components.
Yes, I am still working on this, but wasn't able to finish it due to time constraints and workload.
What speaks against including it as a core feature? It was a core feature in Shopware 5 and helped integrators and agencies a lot when identifying modifications on the code. |
@M-arcus in general for us, the question is rather: why does it need to be in core? A few points we discussed:
We don't doubt it's absolutely useful, but we're not convinced it should be in core. From our perspective it would be better as an extension. And not just better for us in terms of maintenance load, it's better for you and the ecosystem because you can iterate as you please. Is there something special you cannot do as an extension? |
@AydinHassan I will move the code from this PR to a PR in https://github.com/FriendsOfShopware/FroshTools as a similar functionality already exists there, but only for changes in the core. |
@M-arcus thanks for understanding! |
1. Why is this change necessary?
Plugin developers have no way to see if their plugin code has been modified other than checking each file. This functionality was included in Shopware 5.
2. What does this change do, exactly?
It adds 2 commands and a modal in the administration that allows the creation and checking of a checksum.
3. Describe each step to reproduce the issue or behavior.
4. Please link to the relevant issues (if any).
5. Checklist