Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use open-uri for IRKit::App::Data #6

Merged
merged 1 commit into from
Jan 3, 2015
Merged

Use open-uri for IRKit::App::Data #6

merged 1 commit into from
Jan 3, 2015

Conversation

riywo
Copy link
Contributor

@riywo riywo commented Jan 3, 2015

I want to keep my irkit.json secret from my application repository itself, so I made this change to use open-uri for IRKit::App::Data like below:

$ IRKIT_DATA_FILE=https://gist.githubusercontent.com/riywo/.../irkit.json irkit --list
~> https://gist.githubusercontent.com/riywo/.../irkit.json
== Data
foo
bar
== Devices
living  Internet API
10.0.1.17   irkit933c (bonjour)

This makes easy to use ruby-irkit in Heroku.

Thanks!

@shokai
Copy link
Owner

shokai commented Jan 3, 2015

cool!

shokai added a commit that referenced this pull request Jan 3, 2015
@shokai
Merge pull request #6 from riywo/data-file-open-uri
7ebb687 
Use open-uri for IRKit::App::Data
@shokai shokai merged commit 7ebb687 into shokai:master Jan 3, 2015
@riywo riywo deleted the data-file-open-uri branch January 3, 2015 12:20
@riywo
Copy link
Contributor Author

riywo commented Jan 3, 2015

Thanks!

@shokai
Copy link
Owner

shokai commented Jan 3, 2015

I've shipped v0.0.9 to rubygems.org http://rubygems.org/gems/irkit

@riywo
Copy link
Contributor Author

riywo commented Jan 3, 2015

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riywo @shokai