Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support core::error in Rust 1.81 #463

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Support core::error in Rust 1.81 #463

merged 2 commits into from
Sep 23, 2024

Conversation

shepmaster
Copy link
Owner

No description provided.

@shepmaster shepmaster added the enhancement New feature or request label Aug 26, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 26, 2024 •
edited
Loading

✅ Deploy Preview for shepmaster-snafu ready!

Name Link
🔨 Latest commit 695247b
🔍 Latest deploy log https://app.netlify.com/sites/shepmaster-snafu/deploys/66f1878182dad5000891a1bc
😎 Deploy Preview https://deploy-preview-463--shepmaster-snafu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Enet4
Enet4 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I just left a comment on what could eventually be a very tiny misinterpretation of the internal code, but I will not block the PR over it.

src/lib.rs Outdated Show resolved Hide resolved
@Nicceboy Nicceboy mentioned this pull request Sep 14, 2024
Closed
@ognevny
Copy link

ognevny commented Sep 21, 2024

what's progress with this?

@shepmaster shepmaster changed the title Prepare for core::error stabilization Support core::error in Rust 1.81 Sep 23, 2024
@shepmaster shepmaster merged commit 6111b50 into main Sep 23, 2024
12 checks passed
@shepmaster shepmaster deleted the rust-1.81 branch September 23, 2024 15:25
@shepmaster
Copy link
Owner Author

what's progress with this?

Released in 0.8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shepmaster @ognevny @Enet4