Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow webpack-dev-server v5 #418

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: allow webpack-dev-server v5 #418

merged 2 commits into from
Mar 5, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Feb 12, 2024

Summary

This was released a few hours ago, and is needed to patch a vulnerability.

Pull Request checklist

Remove this line after checking all the items here. If the item does not apply to the PR, both check it out and wrap it by ~.

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

This looks to be working fine out of the box for me, though I'll do a look through the actual changelog later to determine if there's any followup work; would be good to get this released in the meantime though. looks like they just removed a bunch of previously deprecated stuff; my CSP is broken for some reason but that isn't Shakapackers problem

@justin808 justin808 merged commit 49e4b2c into shakacode:main Mar 5, 2024
@justin808
Copy link
Member

Thanks @tomdracz and @G-Rath !

@G-Rath G-Rath deleted the patch-3 branch March 5, 2024 07:25
tomdracz pushed a commit that referenced this pull request Mar 6, 2024
* fix: allow `webpack-dev-server` v5

* docs: update changelog
@rwojsznis
Copy link

Hey folks, any change for cutting a new release here? 👀

@justin808
Copy link
Member

Shipped @rwojsznis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants