-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support spaces in app path #322
Support spaces in app path #322
Conversation
May you create a minimal app, demonstrating the issue? |
Easiest way to replicate the issue is to create a new app in the folder with space (in this case
|
Do you really need to have your app in a directory with such name? This is not considered a good practice to name files or directories with spaces. |
@ahangarha please test this and I'll ship 7.0.3 with this. Please update the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I tested your changes and it works as expected.
I added few comments. Take a look at them please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to support spaces in the path for tests, there are more cases to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are currently passing, only this one had any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
@justin808 This PR looks good to me.
@kukicola @justin808 |
@kukicola I don't think you did it in the right way. @justin808 do you have any other consideration? |
@ahangarha I merged. You can add another commit and I can release a new version. |
Summary
Hello, when upgrading my app from v6 to v7, I noticed some commands are failing because I have a space in the absolute path of my project.
Pull Request checklist
Update documentationOther Information