-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up duplicated yarn install #238
Conversation
1. Redefinition of yarn:install caused yarn to run twice ALWAYS as Rails already does trigger a yarn install 2. Removed code no longer needed as Rails 5.2 is the oldest version supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for v7 @justin808 ? I didn't add those files, just restored them. We've originally attempted this in https://github.com/shakacode/shakapacker/pull/131/files
But then I've rolled it back as a response to comments in #125
Happy with the changes but definitely breaking change for a major release
But I guess since we're just targeting 5.2 and above it makes sense with the changes that are here. Wondering how long yarn install tak will survive in rails itself though 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
If we don't need to add a test for it, it can be merged.
It seems like 6.5.6 was never published to Rubygems. Is that intentional? |
@grncdr Thanks for sharing this. |
No problem, I've found a different workaround for my CI, so I'm fine to wait/use a 7.0 beta whenever that's available. |
this change breaks the CI pipeline in one of my apps that I upgraded from webpacker to shakapacker (Rails 5 => Rails 7). Why is it considered redundant? I don't have a separate So, Rails does not provide this trigger and it was always coming from webpacker/shakapacker. jsbundling-rails gem supports this by enhancing
and as I mentioned, in many cases, e.g. on the AWS Elastic Beanstalk platform this is the desired behaviour. EB invokes |
Honestly, I think this feature should stay (as jsbundling-rails, a solution "competitive/alternative" to shakapacker provides this), but should be controlled with the config option that was present before (webpacker_compile ...), set to false by default |
@januszm Is your problem similar to this issue? |
Closes #237