Rewrite tests with RSpec #218
Conversation
|
@ahangarha many added files. Are some being deleted? |
|
Yes. Minitests should be deleted. Since these files are mapping minitest files, we can modify commits in a way that we dont delete old files and create new ones. Is this more desirable? |
|
Hi, Just out of curiosity, can I ask the main reasons behind this change? |
|
We'll make the tests more similar to the test suite of https://github.com/shakacode/react_on_rails. |
@ahangarha you can delete the old ones if you're sure that they're all covered. |
ahangarha
force-pushed
the
rewrite-tests-with-rspec
branch
from
fb287c5 to
388203f
Compare
|
Lots to go through but looks good to me so far! 🎉 |
@justin808 I have just noticed that Update: |
ahangarha
force-pushed
the
rewrite-tests-with-rspec
branch
2 times, most recently
from
0c01ec7 to
8a6e659
Compare
ahangarha
force-pushed
the
rewrite-tests-with-rspec
branch
from
2fb986e to
8a6e659
Compare
Improve tests
This spec is already tested more robustly in the following dedicated files: - env_spec.erb - configuration_spec.rb
ahangarha
force-pushed
the
rewrite-tests-with-rspec
branch
from
66a01a4 to
6168195
Compare
All tests were rewritten in RSpec.
WIP:
bundle exec rake#210)testdirectory)I didn't squash commits to keep the history for review.
For review please check two files more carefully:
helper_spec.rb(if there is a better way rather than extending modules)webpack_runner_spec.rb(if the expectation is the intended one. I have changed the way it tests the result)Also regarding binstubs, I ensured that not only do we check if we have added the relevant files in bin directory, but also only those files are added. This not only resolves the mentioned issue, but it might also be helpful to force any future changes for binstubs to be reflected in our tests.