Describe keys for dev_server in generated webpacker.yml #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
reviewed
Nov 2, 2022
| # port: 8080 | ||
| # Should we use gzip compression? | ||
| compress: true | ||
| # Note that apps that do not check the host are vulnerable to DNS rebinding attacks | ||
| allowed_hosts: "all" | ||
| allowed_hosts: 'all' |
There was a problem hiding this comment.
Why use quotes at all?
Why prefer single?
There was a problem hiding this comment.
We can remove them, but if we keep them better to have same quotes everywhere (IMHO) and there are more single quotes in this file.
| @@ -41,8 +41,14 @@ development: | |||
| port: 3035 | |||
| public: localhost:3035 | |||
| hmr: false | |||
| # Inline should be set to true if using HMR | |||
| inline: true | |||
There was a problem hiding this comment.
Why removing? In-line is a different unrelated option?
There was a problem hiding this comment.
I've searched and inline doesn't seem to be used anywhere, only inline_css. Namely, here
shakapacker/lib/webpacker/dev_server.rb
Line 59 in 0f688bc
fetch(:inline) calls.
| dev_server: | ||
| https: false | ||
| host: localhost | ||
| port: 3035 | ||
| # Hot Module Replacement updates modules while the application is running without a full reload | ||
| # Used instead of the `hot` key in https://webpack.js.org/configuration/dev-server/#devserverhot |
There was a problem hiding this comment.
My thinking was to document only our own keys, but yes, documenting everything makes sense.
justin808
approved these changes
Nov 15, 2022
|
@alexeyr please resolve conflicts and merge. |
alexeyr-ci1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix
inlinetoinline_cssin some test files, though it didn't affect results because the default isinline_css: true.